[Webkit-unassigned] [Bug 163549] Rename the reject() helper function to something more meaningful.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163549

Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com,
                   |                            |fpizlo at apple.com,
                   |                            |ggaren at apple.com,
                   |                            |jfbastien at apple.com,
                   |                            |keith_miller at apple.com,
                   |                            |msaboff at apple.com,
                   |                            |sbarati at apple.com,
                   |                            |utatane.tea at gmail.com
             Status|NEW                         |ASSIGNED
           Assignee|webkit-unassigned at lists.web |mark.lam at apple.com
                   |kit.org                     |

--- Comment #1 from Mark Lam <mark.lam at apple.com> ---
I spoke with Geoff offline, and he suggested renaming reject() to typeError().  The intuition behind this is that all the clients that uses this function will return typeError(..., shouldThrow, ...).  In a sense, they are returning a "type" of TypeError (which happened to be the value false).  In addition, it may also throw a JS TypeError is the shouldThrow parameter is true.

I think that that name works.  I will go ahead and make the change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161026/72778713/attachment-0001.html>