<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span> changed
<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Rename the reject() helper function to something more meaningful."
href="https://bugs.webkit.org/show_bug.cgi?id=163549">bug 163549</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>darin@apple.com, fpizlo@apple.com, ggaren@apple.com, jfbastien@apple.com, keith_miller@apple.com, msaboff@apple.com, sbarati@apple.com, utatane.tea@gmail.com
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>ASSIGNED
</td>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>webkit-unassigned@lists.webkit.org
</td>
<td>mark.lam@apple.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Rename the reject() helper function to something more meaningful."
href="https://bugs.webkit.org/show_bug.cgi?id=163549#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Rename the reject() helper function to something more meaningful."
href="https://bugs.webkit.org/show_bug.cgi?id=163549">bug 163549</a>
from <span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span></b>
<pre>I spoke with Geoff offline, and he suggested renaming reject() to typeError(). The intuition behind this is that all the clients that uses this function will return typeError(..., shouldThrow, ...). In a sense, they are returning a "type" of TypeError (which happened to be the value false). In addition, it may also throw a JS TypeError is the shouldThrow parameter is true.
I think that that name works. I will go ahead and make the change.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>