[Webkit-unassigned] [Bug 163846] [GTK] JSC test wasm.yaml/wasm/js-api/test_basic_api.js.default-wasm and wasm.yaml/wasm/js-api/test_Module.js.default-wasm fail with Exception: ReferenceError: Can't find variable: WebAssembly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163846

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #3)
> I'm not an expert as how tests work, but I'm guessing the problem came from
> here:
>   https://bugs.webkit.org/attachment.cgi?id=291661
> 
> When I added runWebAssembly:
>  
> https://trac.webkit.org/browser/trunk/Tools/Scripts/run-jsc-stress-
> tests#L1157
> 
> Can you confirm that this is the case?

Nope, I honestly don't know how to check JS test results that far back. :( I'm sure there's a way....

> Are the conditions at the top wrong for GTK?

They look sane to me.

> Sorry for asking all these questions, I don't understand how this all holds
> together.

Me either! I think we need to figure out how it is that WebAssembly works at all on the Mac port, then decide if it's ready to be turned on for other ports or not. If it's not ready yet, then we should find a way to skip the test conditional on whether or not it's enabled. 

Alternatively, we could modify the test to pass whenever the WebAssembly variable is not defined, and assume that we would notice if such a major feature accidentally disappeared.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161025/a772287f/attachment.html>