[Webkit-unassigned] [Bug 163846] [GTK] JSC test wasm.yaml/wasm/js-api/test_basic_api.js.default-wasm and wasm.yaml/wasm/js-api/test_Module.js.default-wasm fail with Exception: ReferenceError: Can't find variable: WebAssembly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 25 17:15:38 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=163846

--- Comment #5 from JF Bastien <jfbastien at apple.com> ---
> > Are the conditions at the top wrong for GTK?
> 
> They look sane to me.

Hmm, I don't think they are:

$isFTLPlatform = !($architecture == "x86" || $architecture == "arm" || $hostOS == "windows" || $hostOS == "linux" && $architecture == "arm64")

We'd need a way to see if the platform built with ENABLE(WEBASSEMBLY). I'm not sure how this is done.

> Me either! I think we need to figure out how it is that WebAssembly works at
> all on the Mac port, then decide if it's ready to be turned on for other
> ports or not. If it's not ready yet, then we should find a way to skip the
> test conditional on whether or not it's enabled. 

It's not ready yet, and we're only concentrating on Mac bits right now so some of the code will need Linux-isms to work well on Linux. I wouldn't enable it yet, unless someone is willing to do the Linux work.


> Alternatively, we could modify the test to pass whenever the WebAssembly
> variable is not defined, and assume that we would notice if such a major
> feature accidentally disappeared.

I'd rather not since the entire point is to test that WebAssembly works. It's unlikely that we'd mess that up, but still it's not released so nobody would notice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161026/668571fa/attachment-0001.html>


More information about the webkit-unassigned mailing list