[Webkit-unassigned] [Bug 154667] Update twisted version in webkitpy.thirdparty.autoinstalled module.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154667

--- Comment #19 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
I have tested this. It works fine on the GTK+ platform.

But I see that it won't auto-install twisted 15.0 or use it if the system already has python-twisted installed.

If you want to ensure this script always uses twisted 15.0 you can try something like:


--- a/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py
+++ b/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py
@@ -5,11 +5,8 @@ import logging
 import os
 import sys

-try:
-    import twisted
-except ImportError:
-    sys.path.append(os.path.abspath(os.path.join(os.path.dirname(os.path.abspath(__file__)), '../../../..')))
-    from webkitpy.thirdparty.autoinstalled.twisted import twisted
+sys.path.append(os.path.abspath(os.path.join(os.path.dirname(os.path.abspath(__file__)), '../../../..')))
+from webkitpy.thirdparty.autoinstalled.twisted_15_5_0 import twisted

 from twisted.web import static, server
 from twisted.web.resource import Resource




By the way.. what is the context for requiring twisted 15.0 here?
Is it necessary for some run-benchmark test?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161025/8a7a2c8f/attachment.html>