<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Update twisted version in webkitpy.thirdparty.autoinstalled module."
href="https://bugs.webkit.org/show_bug.cgi?id=154667#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Update twisted version in webkitpy.thirdparty.autoinstalled module."
href="https://bugs.webkit.org/show_bug.cgi?id=154667">bug 154667</a>
from <span class="vcard"><a class="email" href="mailto:clopez@igalia.com" title="Carlos Alberto Lopez Perez <clopez@igalia.com>"> <span class="fn">Carlos Alberto Lopez Perez</span></a>
</span></b>
<pre>I have tested this. It works fine on the GTK+ platform.
But I see that it won't auto-install twisted 15.0 or use it if the system already has python-twisted installed.
If you want to ensure this script always uses twisted 15.0 you can try something like:
--- a/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py
+++ b/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py
@@ -5,11 +5,8 @@ import logging
import os
import sys
-try:
- import twisted
-except ImportError:
- sys.path.append(os.path.abspath(os.path.join(os.path.dirname(os.path.abspath(__file__)), '../../../..')))
- from webkitpy.thirdparty.autoinstalled.twisted import twisted
+sys.path.append(os.path.abspath(os.path.join(os.path.dirname(os.path.abspath(__file__)), '../../../..')))
+from webkitpy.thirdparty.autoinstalled.twisted_15_5_0 import twisted
from twisted.web import static, server
from twisted.web.resource import Resource
By the way.. what is the context for requiring twisted 15.0 here?
Is it necessary for some run-benchmark test?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>