[Webkit-unassigned] [Bug 163327] WebRTC: [GTK] Add MediaEndpointOwr - an OpenWebRTC WebRTC backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163327

--- Comment #9 from Adam Bergkvist <adam.bergkvist at ericsson.com> ---
(In reply to comment #6)
> Comment on attachment 292236 [details]
> Updated patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=292236&action=review
> 
> > Source/WebCore/platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:352
> > +    owr_media_session_set_send_source(OWR_MEDIA_SESSION(transceiver->session()), owrSource.mediaSource());
> 
> So this won't work then? Maybe replace with notImplemented() ?

Fixed.

(In reply to comment #7)
> (In reply to comment #4)
> > > > Source/WebCore/platform/mediastream/openwebrtc/MediaEndpointOwr.h:37
> > > > +#include <owr/owr_media_session.h>
> > > > +#include <owr/owr_transport_agent.h>
> > > 
> > > Maybe use forward declarations of the structs needed and move includes to
> > > the .cpp file, if possible :)
> > 
> > It made a try, but it gets a bit messy since all the OWR types are typedefs
> > (of structs).
> 
> typedef struct _Foo Foo;
> 
> We do this in some of the player headers for Gst structs.
> The issue usually is with C enums that can't be forward-declared.

Fixed. We need owr_session.h in the header for the OwrIceState enum.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161021/f9abe30b/attachment-0001.html>