<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: [GTK] Add MediaEndpointOwr - an OpenWebRTC WebRTC backend"
href="https://bugs.webkit.org/show_bug.cgi?id=163327#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WebRTC: [GTK] Add MediaEndpointOwr - an OpenWebRTC WebRTC backend"
href="https://bugs.webkit.org/show_bug.cgi?id=163327">bug 163327</a>
from <span class="vcard"><a class="email" href="mailto:adam.bergkvist@ericsson.com" title="Adam Bergkvist <adam.bergkvist@ericsson.com>"> <span class="fn">Adam Bergkvist</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=163327#c6">comment #6</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=292236&action=diff" name="attach_292236" title="Updated patch">attachment 292236</a> <a href="attachment.cgi?id=292236&action=edit" title="Updated patch">[details]</a></span>
> Updated patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=292236&action=review">https://bugs.webkit.org/attachment.cgi?id=292236&action=review</a>
>
> > Source/WebCore/platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:352
> > + owr_media_session_set_send_source(OWR_MEDIA_SESSION(transceiver->session()), owrSource.mediaSource());
>
> So this won't work then? Maybe replace with notImplemented() ?</span >
Fixed.
(In reply to <a href="show_bug.cgi?id=163327#c7">comment #7</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=163327#c4">comment #4</a>)
> > > > Source/WebCore/platform/mediastream/openwebrtc/MediaEndpointOwr.h:37
> > > > +#include <owr/owr_media_session.h>
> > > > +#include <owr/owr_transport_agent.h>
> > >
> > > Maybe use forward declarations of the structs needed and move includes to
> > > the .cpp file, if possible :)
> >
> > It made a try, but it gets a bit messy since all the OWR types are typedefs
> > (of structs).
>
> typedef struct _Foo Foo;
>
> We do this in some of the player headers for Gst structs.
> The issue usually is with C enums that can't be forward-declared.</span >
Fixed. We need owr_session.h in the header for the OwrIceState enum.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>