[Webkit-unassigned] [Bug 163733] New: [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163733

            Bug ID: 163733
           Summary: [EFL] REGRESSION(r207616): Build is broken due to
                    missing libgeoclue-dev package
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Critical
          Priority: P1
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ossy at webkit.org
                CC: cgarcia at igalia.com, clopez at igalia.com,
                    gyuyoung.kim at webkit.org, hs85.jeong at samsung.com
            Blocks: 160809

I tried an EFL WebKit build on a fresh new Ubuntu 16.04 
machine and got the following build error:

In file included from ../../Source/WebCore/platform/geoclue/GeolocationProviderGeoclue1.cpp:27:0:
../../Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.h:32:36: fatal error: geoclue/geoclue-master.h: No such file or directory
compilation terminated.

It seems https://trac.webkit.org/changeset/204445 is the culprit.

geoclue/geoclue-master.h is in libgeoclue-dev package, 
but after r204445, only libgeoclue-2-dev is installed.

But the question is what is the proper fix?
- adding geoclue-2.0 to <efl|gtk>/install-dependencies
  --> isn't enough, because USE(GEOCLUE2) isn't exposed to the build
- Source/cmake/OptionsEfl.cmake should use SET_AND_EXPOSE_TO_BUILD similar to GTK 
- fixing the geoclue 1 build
- removing the geoclue path
- whatever else

Additionally I got the following warnings which should be fixed or suppressed:
DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_manager_complete_get_client':
DerivedSources/WebCore/Geoclue2Interface.c:673:21: warning: unused parameter 'object' [-Wunused-parameter]
DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_manager_complete_add_agent':
DerivedSources/WebCore/Geoclue2Interface.c:693:21: warning: unused parameter 'object' [-Wunused-parameter]
DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_client_complete_start':
DerivedSources/WebCore/Geoclue2Interface.c:2373:20: warning: unused parameter 'object' [-Wunused-parameter]
DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_client_complete_stop':
DerivedSources/WebCore/Geoclue2Interface.c:2391:20: warning: unused parameter 'object' [-Wunused-parameter]


note: I just reported this bug, but have no time and interest 
in fixing it myself. I'm going to upload my WIP patch, feel 
free to pick it up if it is important for somebody.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161020/d0901a71/attachment-0001.html>