<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package"
href="https://bugs.webkit.org/show_bug.cgi?id=163733">163733</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>Other
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Critical
</td>
</tr>
<tr>
<th>Priority</th>
<td>P1
</td>
</tr>
<tr>
<th>Component</th>
<td>New Bugs
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>ossy@webkit.org
</td>
</tr>
<tr>
<th>CC</th>
<td>cgarcia@igalia.com, clopez@igalia.com, gyuyoung.kim@webkit.org, hs85.jeong@samsung.com
</td>
</tr>
<tr>
<th>Blocks</th>
<td>160809
</td>
</tr></table>
<p>
<div>
<pre>I tried an EFL WebKit build on a fresh new Ubuntu 16.04
machine and got the following build error:
In file included from ../../Source/WebCore/platform/geoclue/GeolocationProviderGeoclue1.cpp:27:0:
../../Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.h:32:36: fatal error: geoclue/geoclue-master.h: No such file or directory
compilation terminated.
It seems <a href="https://trac.webkit.org/changeset/204445">https://trac.webkit.org/changeset/204445</a> is the culprit.
geoclue/geoclue-master.h is in libgeoclue-dev package,
but after r204445, only libgeoclue-2-dev is installed.
But the question is what is the proper fix?
- adding geoclue-2.0 to <efl|gtk>/install-dependencies
--> isn't enough, because USE(GEOCLUE2) isn't exposed to the build
- Source/cmake/OptionsEfl.cmake should use SET_AND_EXPOSE_TO_BUILD similar to GTK
- fixing the geoclue 1 build
- removing the geoclue path
- whatever else
Additionally I got the following warnings which should be fixed or suppressed:
DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_manager_complete_get_client':
DerivedSources/WebCore/Geoclue2Interface.c:673:21: warning: unused parameter 'object' [-Wunused-parameter]
DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_manager_complete_add_agent':
DerivedSources/WebCore/Geoclue2Interface.c:693:21: warning: unused parameter 'object' [-Wunused-parameter]
DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_client_complete_start':
DerivedSources/WebCore/Geoclue2Interface.c:2373:20: warning: unused parameter 'object' [-Wunused-parameter]
DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_client_complete_stop':
DerivedSources/WebCore/Geoclue2Interface.c:2391:20: warning: unused parameter 'object' [-Wunused-parameter]
note: I just reported this bug, but have no time and interest
in fixing it myself. I'm going to upload my WIP patch, feel
free to pick it up if it is important for somebody.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>