[Webkit-unassigned] [Bug 163597] [SOUP] Add NetworkSession implementation and switch to use it

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 18 23:07:29 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=163597

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #4)
> Comment on attachment 291949 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=291949&action=review
> 
> > Source/WebKit2/NetworkProcess/NetworkDataTask.h:147
> > +    bool isDownload() const { return !!m_pendingDownloadID.downloadID(); }
> 
> Could we call this isPendingDownload?

That's only true for Cocoa, in soup we don't have a download task, it's the same data task that becomes a download, so after the task is converted into a download it's no longer pending.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161019/b208581a/attachment.html>


More information about the webkit-unassigned mailing list