<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Add NetworkSession implementation and switch to use it"
href="https://bugs.webkit.org/show_bug.cgi?id=163597#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Add NetworkSession implementation and switch to use it"
href="https://bugs.webkit.org/show_bug.cgi?id=163597">bug 163597</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=163597#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=291949&action=diff" name="attach_291949" title="Patch">attachment 291949</a> <a href="attachment.cgi?id=291949&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=291949&action=review">https://bugs.webkit.org/attachment.cgi?id=291949&action=review</a>
>
> > Source/WebKit2/NetworkProcess/NetworkDataTask.h:147
> > + bool isDownload() const { return !!m_pendingDownloadID.downloadID(); }
>
> Could we call this isPendingDownload?</span >
That's only true for Cocoa, in soup we don't have a download task, it's the same data task that becomes a download, so after the task is converted into a download it's no longer pending.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>