[Webkit-unassigned] [Bug 163610] AX: [Mac] Meter element should use AXValueDescription to descrbe the status of the value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163610

--- Comment #6 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 291982
  --> https://bugs.webkit.org/attachment.cgi?id=291982
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291982&action=review

>>> Source/WebCore/accessibility/AccessibilityProgressIndicator.cpp:175
>>> +    if (!m_renderer || !m_renderer->isMeter())
>> 
>> why do we only want this on COCOA? (does COCOA also mean iOS?)
> 
> Because the localized string is in cocoa, I followed other mac only descriptions. I think it's both mac and iOS. But Meter is not currently supported on iOS. Should we wrap with platform(mac)?

I think the #if FEATURE(METER) flag would handle that. so maybe we use COCOA and METER

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2620
> +        if (builder.length())

is there no better way to do this? does stringBuilder have methods for this kind of scenario?

> Source/WebCore/platform/LocalizedStrings.cpp:786
> +    if (value == "optimum")

I don't think we need to use strings here for the value. It seems like using an enum would be better. less copying required

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161018/1ec6a228/attachment-0001.html>