<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: [Mac] Meter element should use AXValueDescription to descrbe the status of the value"
href="https://bugs.webkit.org/show_bug.cgi?id=163610#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: [Mac] Meter element should use AXValueDescription to descrbe the status of the value"
href="https://bugs.webkit.org/show_bug.cgi?id=163610">bug 163610</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=291982&action=diff" name="attach_291982" title="patch">attachment 291982</a> <a href="attachment.cgi?id=291982&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=291982&action=review">https://bugs.webkit.org/attachment.cgi?id=291982&action=review</a>
<span class="quote">>>> Source/WebCore/accessibility/AccessibilityProgressIndicator.cpp:175
>>> + if (!m_renderer || !m_renderer->isMeter())
>>
>> why do we only want this on COCOA? (does COCOA also mean iOS?)
>
> Because the localized string is in cocoa, I followed other mac only descriptions. I think it's both mac and iOS. But Meter is not currently supported on iOS. Should we wrap with platform(mac)?</span >
I think the #if FEATURE(METER) flag would handle that. so maybe we use COCOA and METER
<span class="quote">> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2620
> + if (builder.length())</span >
is there no better way to do this? does stringBuilder have methods for this kind of scenario?
<span class="quote">> Source/WebCore/platform/LocalizedStrings.cpp:786
> + if (value == "optimum")</span >
I don't think we need to use strings here for the value. It seems like using an enum would be better. less copying required</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>