[Webkit-unassigned] [Bug 163406] Add test and infrastructure for link popover

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163406

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291900|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 291900
  --> https://bugs.webkit.org/attachment.cgi?id=291900
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291900&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3854
> +        return @{ userInterfaceItem: @{@"pageURL": url}};

Perferred spacing here would be:
@{ userInterfaceItem: @{ @"pageURL": url } };

> LayoutTests/fast/events/touch/ios/iphone7/force-press-on-link.html:65
> +                uiController.liftUpAtPoint(20,40,1,function() {

Spaces after commas please.

> LayoutTests/fast/events/touch/ios/iphone7/force-press-on-link.html:87
> +                        document.getElementById('target').innerHTML = output;

I think it's OK to do this before this testRunner.runUIScript() invocation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161018/f947bf13/attachment.html>