<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add test and infrastructure for link popover"
href="https://bugs.webkit.org/show_bug.cgi?id=163406">bug 163406</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #291900 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add test and infrastructure for link popover"
href="https://bugs.webkit.org/show_bug.cgi?id=163406#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add test and infrastructure for link popover"
href="https://bugs.webkit.org/show_bug.cgi?id=163406">bug 163406</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=291900&action=diff" name="attach_291900" title="Patch">attachment 291900</a> <a href="attachment.cgi?id=291900&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=291900&action=review">https://bugs.webkit.org/attachment.cgi?id=291900&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3854
> + return @{ userInterfaceItem: @{@"pageURL": url}};</span >
Perferred spacing here would be:
@{ userInterfaceItem: @{ @"pageURL": url } };
<span class="quote">> LayoutTests/fast/events/touch/ios/iphone7/force-press-on-link.html:65
> + uiController.liftUpAtPoint(20,40,1,function() {</span >
Spaces after commas please.
<span class="quote">> LayoutTests/fast/events/touch/ios/iphone7/force-press-on-link.html:87
> + document.getElementById('target').innerHTML = output;</span >
I think it's OK to do this before this testRunner.runUIScript() invocation.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>