[Webkit-unassigned] [Bug 163406] Add test and infrastructure for link popover

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163406

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291882|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 291882
  --> https://bugs.webkit.org/attachment.cgi?id=291882
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291882&action=review

Good patch, but the test needs tweaking.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3852
> +    if ([userInterfaceItem isEqualToString:@"popoverContents"]) {

@"popoverContents" seems a bit too generic; I think it should be @"linkPreviewPopoverURL" or something.

> LayoutTests/fast/events/touch/ios/iphone7/force-press-on-link.html:56
> +                    uiController.uiScriptComplete(JSON.stringify(uiController.contentsOfUserInterfaceItem('popoverContents')));
> +                    uiController.liftUpAtPoint(20,40,1,function() {});

This is racey. In the uiController.uiScriptComplete() callback, the web process does testRunner.notifyDone(), so may start moving onto the next test.

What you should do instead is have a second testRunner.runUIScript() below, have that fire the uiController.liftUpAtPoint(), and only notifyDone() when that second one completes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161017/eb24cf5b/attachment.html>