<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add test and infrastructure for link popover"
href="https://bugs.webkit.org/show_bug.cgi?id=163406">bug 163406</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #291882 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add test and infrastructure for link popover"
href="https://bugs.webkit.org/show_bug.cgi?id=163406#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add test and infrastructure for link popover"
href="https://bugs.webkit.org/show_bug.cgi?id=163406">bug 163406</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=291882&action=diff" name="attach_291882" title="Patch">attachment 291882</a> <a href="attachment.cgi?id=291882&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=291882&action=review">https://bugs.webkit.org/attachment.cgi?id=291882&action=review</a>
Good patch, but the test needs tweaking.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3852
> + if ([userInterfaceItem isEqualToString:@"popoverContents"]) {</span >
@"popoverContents" seems a bit too generic; I think it should be @"linkPreviewPopoverURL" or something.
<span class="quote">> LayoutTests/fast/events/touch/ios/iphone7/force-press-on-link.html:56
> + uiController.uiScriptComplete(JSON.stringify(uiController.contentsOfUserInterfaceItem('popoverContents')));
> + uiController.liftUpAtPoint(20,40,1,function() {});</span >
This is racey. In the uiController.uiScriptComplete() callback, the web process does testRunner.notifyDone(), so may start moving onto the next test.
What you should do instead is have a second testRunner.runUIScript() below, have that fire the uiController.liftUpAtPoint(), and only notifyDone() when that second one completes.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>