[Webkit-unassigned] [Bug 163105] [GTK] gobject-introspection on package build with webkit2gtk fails without active X session

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163105

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291797|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 291797
  --> https://bugs.webkit.org/attachment.cgi?id=291797
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291797&action=review

> Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:78
> -    if (!m_supportsXComposite) {
> +    if (!m_supportsXComposite && m_display) {

I agree but this will crash in debug builds. m_supportsXComposite is Optional<bool>, if we don't initialize it the .value() below will assert in debug because the value is not engaged. So, simply add an early return before this if so that when m_display is nullptr, the optional value is not even used.

> Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:87
> -    if (!m_supportsXDamage) {
> +    if (!m_supportsXDamage && m_display) {

And same here

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161017/5da46fd1/attachment-0001.html>