<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] gobject-introspection on package build with webkit2gtk fails without active X session"
href="https://bugs.webkit.org/show_bug.cgi?id=163105">bug 163105</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #291797 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] gobject-introspection on package build with webkit2gtk fails without active X session"
href="https://bugs.webkit.org/show_bug.cgi?id=163105#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] gobject-introspection on package build with webkit2gtk fails without active X session"
href="https://bugs.webkit.org/show_bug.cgi?id=163105">bug 163105</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=291797&action=diff" name="attach_291797" title="Patch">attachment 291797</a> <a href="attachment.cgi?id=291797&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=291797&action=review">https://bugs.webkit.org/attachment.cgi?id=291797&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:78
> - if (!m_supportsXComposite) {
> + if (!m_supportsXComposite && m_display) {</span >
I agree but this will crash in debug builds. m_supportsXComposite is Optional<bool>, if we don't initialize it the .value() below will assert in debug because the value is not engaged. So, simply add an early return before this if so that when m_display is nullptr, the optional value is not even used.
<span class="quote">> Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:87
> - if (!m_supportsXDamage) {
> + if (!m_supportsXDamage && m_display) {</span >
And same here</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>