[Webkit-unassigned] [Bug 163292] Implement displaying context menu asynchronously

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163292

Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291651|review?                     |review-
              Flags|                            |

--- Comment #4 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 291651
  --> https://bugs.webkit.org/attachment.cgi?id=291651
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291651&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.cpp:857
> +            if (m_client.base.version <= 3 || !m_client.getContextMenuFromProposedMenuAsync)

How about:
m_client.base.version < 4

It reads better, I think, referencing the version where the new bits were added.

> Source/WebKit2/UIProcess/WebContextMenuListenerProxy.cpp:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

Update copyright for new files

> Source/WebKit2/UIProcess/WebContextMenuListenerProxy.h:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

Update the copyright date for new files

> Source/WebKit2/UIProcess/WebContextMenuListenerProxy.h:27
> +#ifndef WebContextMenuListenerProxy_h
> +#define WebContextMenuListenerProxy_h

#pragma once

> Source/WebKit2/UIProcess/WebContextMenuListenerProxy.h:47
> +    void useProposedContextMenuItems(WKArrayRef items);

The initial call out to the WK client is "get context menu from proposed menu".

So I wouldn't call the returned menu the "proposed menu" as it has assumedly undergone changes.

I'd suggest "useContentMenuItems"

> Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:470
> +    if (m_contextMenuListener) {
> +        m_contextMenuListener->invalidate();
> +        m_contextMenuListener = nullptr;
> +    }

Very important to invalidate this in the destructor as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161014/70e52ab6/attachment.html>