<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:beidson@apple.com" title="Brady Eidson <beidson@apple.com>"> <span class="fn">Brady Eidson</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement displaying context menu asynchronously"
href="https://bugs.webkit.org/show_bug.cgi?id=163292">bug 163292</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #291651 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement displaying context menu asynchronously"
href="https://bugs.webkit.org/show_bug.cgi?id=163292#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement displaying context menu asynchronously"
href="https://bugs.webkit.org/show_bug.cgi?id=163292">bug 163292</a>
from <span class="vcard"><a class="email" href="mailto:beidson@apple.com" title="Brady Eidson <beidson@apple.com>"> <span class="fn">Brady Eidson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=291651&action=diff" name="attach_291651" title="Patch">attachment 291651</a> <a href="attachment.cgi?id=291651&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=291651&action=review">https://bugs.webkit.org/attachment.cgi?id=291651&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/API/C/WKPage.cpp:857
> + if (m_client.base.version <= 3 || !m_client.getContextMenuFromProposedMenuAsync)</span >
How about:
m_client.base.version < 4
It reads better, I think, referencing the version where the new bits were added.
<span class="quote">> Source/WebKit2/UIProcess/WebContextMenuListenerProxy.cpp:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.</span >
Update copyright for new files
<span class="quote">> Source/WebKit2/UIProcess/WebContextMenuListenerProxy.h:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.</span >
Update the copyright date for new files
<span class="quote">> Source/WebKit2/UIProcess/WebContextMenuListenerProxy.h:27
> +#ifndef WebContextMenuListenerProxy_h
> +#define WebContextMenuListenerProxy_h</span >
#pragma once
<span class="quote">> Source/WebKit2/UIProcess/WebContextMenuListenerProxy.h:47
> + void useProposedContextMenuItems(WKArrayRef items);</span >
The initial call out to the WK client is "get context menu from proposed menu".
So I wouldn't call the returned menu the "proposed menu" as it has assumedly undergone changes.
I'd suggest "useContentMenuItems"
<span class="quote">> Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm:470
> + if (m_contextMenuListener) {
> + m_contextMenuListener->invalidate();
> + m_contextMenuListener = nullptr;
> + }</span >
Very important to invalidate this in the destructor as well.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>