[Webkit-unassigned] [Bug 163436] Document request not updated after willSendRequest is called for a redirect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163436

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291595|review?                     |review+
              Flags|                            |

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 291595
  --> https://bugs.webkit.org/attachment.cgi?id=291595
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291595&action=review

Great tests.

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:225
> +    enum State { Provisional, ProvisionalAfterRedirect, Commited, Finished };

Personally, I'd still favor using enum class even in a file-private unit test class, but your call.

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:254
> +    void checkURIAtState(State state, const char* uri)

Please rename the second parameter (maybe to "path") because it's not a URI.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161014/9cb8b347/attachment.html>