<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:mcatanzaro&#64;igalia.com" title="Michael Catanzaro &lt;mcatanzaro&#64;igalia.com&gt;"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Document request not updated after willSendRequest is called for a redirect"
   href="https://bugs.webkit.org/show_bug.cgi?id=163436">bug 163436</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #291595 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Document request not updated after willSendRequest is called for a redirect"
   href="https://bugs.webkit.org/show_bug.cgi?id=163436#c3">Comment # 3</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Document request not updated after willSendRequest is called for a redirect"
   href="https://bugs.webkit.org/show_bug.cgi?id=163436">bug 163436</a>
              from <span class="vcard"><a class="email" href="mailto:mcatanzaro&#64;igalia.com" title="Michael Catanzaro &lt;mcatanzaro&#64;igalia.com&gt;"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=291595&amp;action=diff" name="attach_291595" title="Patch">attachment 291595</a> <a href="attachment.cgi?id=291595&amp;action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=291595&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=291595&amp;action=review</a>

Great tests.

<span class="quote">&gt; Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:225
&gt; +    enum State { Provisional, ProvisionalAfterRedirect, Commited, Finished };</span >

Personally, I'd still favor using enum class even in a file-private unit test class, but your call.

<span class="quote">&gt; Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:254
&gt; +    void checkURIAtState(State state, const char* uri)</span >

Please rename the second parameter (maybe to &quot;path&quot;) because it's not a URI.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>