[Webkit-unassigned] [Bug 163406] Add test and infrastructure for link popover

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163406

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291526|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 291526
  --> https://bugs.webkit.org/attachment.cgi?id=291526
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291526&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:26
> +#pragma once

Don't add this, since Obj-C's #import already takes care of this.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:274
> +- (void)didShowForcePressPreview WK_API_AVAILABLE(ios(WK_IOS_TBA));
> +- (void)didDismissForcePressPreview WK_API_AVAILABLE(ios(WK_IOS_TBA));

These should have leading underscores ("_didShowForcePressPreview")  - the others need fixing too.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3851
> +    if ([userInterfaceItem isEqualToString:@"popoverContents"]) {

Blank line above please.

> Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:125
> +    // Preview form handling

Maybe "Force press preview handling"

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h:26
> +#pragma once

No need.

> LayoutTests/ChangeLog:9
> +        * fast/events/touch/ios/iphone7/force-press-on-link-expected.txt: Added.
> +        * fast/events/touch/ios/iphone7/force-press-on-link.html: Added.

Does the popover go away when this test is complete?

> LayoutTests/fast/events/touch/ios/iphone7/force-press-on-link.html:96
> +    <a href="http://www.apple.com">Link Test</a>

This should be a local URL, rather than loading a live web site.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161013/d6cc368a/attachment.html>