<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add test and infrastructure for link popover"
href="https://bugs.webkit.org/show_bug.cgi?id=163406">bug 163406</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #291526 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add test and infrastructure for link popover"
href="https://bugs.webkit.org/show_bug.cgi?id=163406#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add test and infrastructure for link popover"
href="https://bugs.webkit.org/show_bug.cgi?id=163406">bug 163406</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=291526&action=diff" name="attach_291526" title="Patch">attachment 291526</a> <a href="attachment.cgi?id=291526&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=291526&action=review">https://bugs.webkit.org/attachment.cgi?id=291526&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:26
> +#pragma once</span >
Don't add this, since Obj-C's #import already takes care of this.
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:274
> +- (void)didShowForcePressPreview WK_API_AVAILABLE(ios(WK_IOS_TBA));
> +- (void)didDismissForcePressPreview WK_API_AVAILABLE(ios(WK_IOS_TBA));</span >
These should have leading underscores ("_didShowForcePressPreview") - the others need fixing too.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3851
> + if ([userInterfaceItem isEqualToString:@"popoverContents"]) {</span >
Blank line above please.
<span class="quote">> Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:125
> + // Preview form handling</span >
Maybe "Force press preview handling"
<span class="quote">> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h:26
> +#pragma once</span >
No need.
<span class="quote">> LayoutTests/ChangeLog:9
> + * fast/events/touch/ios/iphone7/force-press-on-link-expected.txt: Added.
> + * fast/events/touch/ios/iphone7/force-press-on-link.html: Added.</span >
Does the popover go away when this test is complete?
<span class="quote">> LayoutTests/fast/events/touch/ios/iphone7/force-press-on-link.html:96
> + <a href="<a href="http://www.apple.com">http://www.apple.com</a>">Link Test</a></span >
This should be a local URL, rather than loading a live web site.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>