[Webkit-unassigned] [Bug 163367] AX: [Mac] better accessibility support for Summary elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163367

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291464|review?                     |review+
              Flags|                            |

--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 291464
  --> https://bugs.webkit.org/attachment.cgi?id=291464
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291464&action=review

> Source/WebCore/accessibility/AccessibilityObject.h:1066
> +    static AccessibilityObject* matchedParent(AccessibilityObject*, bool includeSelf, const std::function<bool(AccessibilityObject*)>&);

I don’t think the types are quite right here. I think we should probably use const versions and take references. The passed in function should take an AccesibilityObject&, not an AccessibilityObject*.

    static const AccessibilityObject* matchedParent(const AccessibilityObject&, bool includeSelf, const std::function<bool(const AccessibilityObject&)>&);

And if we really need a non-const version (I am not sure we do):

    static AccessibilityObject* matchedParent(AccessibilityObject&, bool includeSelf, const std::function<bool(const AccessibilityObject&)>&);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161013/602113bd/attachment-0001.html>