<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: [Mac] better accessibility support for Summary elements"
href="https://bugs.webkit.org/show_bug.cgi?id=163367">bug 163367</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #291464 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: [Mac] better accessibility support for Summary elements"
href="https://bugs.webkit.org/show_bug.cgi?id=163367#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: [Mac] better accessibility support for Summary elements"
href="https://bugs.webkit.org/show_bug.cgi?id=163367">bug 163367</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=291464&action=diff" name="attach_291464" title="patch">attachment 291464</a> <a href="attachment.cgi?id=291464&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=291464&action=review">https://bugs.webkit.org/attachment.cgi?id=291464&action=review</a>
<span class="quote">> Source/WebCore/accessibility/AccessibilityObject.h:1066
> + static AccessibilityObject* matchedParent(AccessibilityObject*, bool includeSelf, const std::function<bool(AccessibilityObject*)>&);</span >
I don’t think the types are quite right here. I think we should probably use const versions and take references. The passed in function should take an AccesibilityObject&, not an AccessibilityObject*.
static const AccessibilityObject* matchedParent(const AccessibilityObject&, bool includeSelf, const std::function<bool(const AccessibilityObject&)>&);
And if we really need a non-const version (I am not sure we do):
static AccessibilityObject* matchedParent(AccessibilityObject&, bool includeSelf, const std::function<bool(const AccessibilityObject&)>&);</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>