[Webkit-unassigned] [Bug 163353] Share inline stylesheets between shadow trees

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 13 09:57:09 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=163353

--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 291390
  --> https://bugs.webkit.org/attachment.cgi?id=291390
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291390&action=review

>> Source/WebCore/css/parser/CSSParserMode.h:126
>> +        hash ^= WTF::intHash(static_cast<unsigned>(key.mode));
> 
> Is there a better way to combine hash?

Longer term, the better way to hash a bunch of things is to construct a single hasher and then hash one item after another. Doing an exclusive or of hashes is nowhere near as a good as that. To make then hashes better in cases like this one I would like us to make a hasher class that is perhaps a bit like StringBuilder and lets us easily hash a sequence of different types of data and make a single hash out of all of it. Presumably we want to usually avoid both the "exclusive or'd hashes" pattern and even the "hash of hashes" pattern.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161013/41f4ab3a/attachment.html>


More information about the webkit-unassigned mailing list