<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Share inline stylesheets between shadow trees"
href="https://bugs.webkit.org/show_bug.cgi?id=163353#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Share inline stylesheets between shadow trees"
href="https://bugs.webkit.org/show_bug.cgi?id=163353">bug 163353</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=291390&action=diff" name="attach_291390" title="patch">attachment 291390</a> <a href="attachment.cgi?id=291390&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=291390&action=review">https://bugs.webkit.org/attachment.cgi?id=291390&action=review</a>
<span class="quote">>> Source/WebCore/css/parser/CSSParserMode.h:126
>> + hash ^= WTF::intHash(static_cast<unsigned>(key.mode));
>
> Is there a better way to combine hash?</span >
Longer term, the better way to hash a bunch of things is to construct a single hasher and then hash one item after another. Doing an exclusive or of hashes is nowhere near as a good as that. To make then hashes better in cases like this one I would like us to make a hasher class that is perhaps a bit like StringBuilder and lets us easily hash a sequence of different types of data and make a single hash out of all of it. Presumably we want to usually avoid both the "exclusive or'd hashes" pattern and even the "hash of hashes" pattern.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>