[Webkit-unassigned] [Bug 163346] New: [GTK] trunk r207192 fails to compile WebTextChecker* due to missing definition of WKTextCheckerClientBase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163346

            Bug ID: 163346
           Summary: [GTK] trunk r207192 fails to compile WebTextChecker*
                    due to missing definition of WKTextCheckerClientBase
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: jeremyhu at apple.com
                CC: lforschler at apple.com

With trunk r207192 and the buildfix for bug #163340, I'm hitting a compile failure now in WebTextChecker.cpp and WebTextCheckerClient.cpp regarding WKTextCheckerClientBase being unknown.

Given that WebTextChecker.cpp hasn't changed in almost two years and WebTextCheckerClient.cpp hasn't in almost three, it's likely a change to one of their header files 

Source/WebKit2/UIProcess/WebTextChecker.cpp:46:38: error: unknown type name 'WKTextCheckerClientBase'; did you mean 'WebCore::TextCheckerClient'?
void WebTextChecker::setClient(const WKTextCheckerClientBase* client)
                                     ^~~~~~~~~~~~~~~~~~~~~~~
                                     WebCore::TextCheckerClient


and similarly in WebTextCheckerClient.cpp:

Source/WebKit2/UIProcess/WebTextCheckerClient.cpp:27:
Source/WebKit2/UIProcess/WebTextCheckerClient.h:36:32: error: unknown type name 'WKTextCheckerClientBase'; did you mean 'WebCore::TextCheckerClient'?
template<> struct ClientTraits<WKTextCheckerClientBase> {
                               ^~~~~~~~~~~~~~~~~~~~~~~
                               WebCore::TextCheckerClient

---

It's defined in Source/WebKit2/UIProcess/API/C/WKTextChecker.h, and that was modified a few weeks ago as part of bug #161919, r206261.

Looking at that commit, it looks VERY wrong.  There's a ton of defined(__APPLE__) checks which are clearly incorrect.  The changes look related to toolkit, not platform.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161012/5e4e3163/attachment.html>