<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] trunk r207192 fails to compile WebTextChecker* due to missing definition of WKTextCheckerClientBase"
href="https://bugs.webkit.org/show_bug.cgi?id=163346">163346</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>[GTK] trunk r207192 fails to compile WebTextChecker* due to missing definition of WKTextCheckerClientBase
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Tools / Tests
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>jeremyhu@apple.com
</td>
</tr>
<tr>
<th>CC</th>
<td>lforschler@apple.com
</td>
</tr></table>
<p>
<div>
<pre>With trunk r207192 and the buildfix for <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] trunk r207192 fails to compile due to missing std::function being unavailable (missing #include <functional>)"
href="show_bug.cgi?id=163340">bug #163340</a>, I'm hitting a compile failure now in WebTextChecker.cpp and WebTextCheckerClient.cpp regarding WKTextCheckerClientBase being unknown.
Given that WebTextChecker.cpp hasn't changed in almost two years and WebTextCheckerClient.cpp hasn't in almost three, it's likely a change to one of their header files
Source/WebKit2/UIProcess/WebTextChecker.cpp:46:38: error: unknown type name 'WKTextCheckerClientBase'; did you mean 'WebCore::TextCheckerClient'?
void WebTextChecker::setClient(const WKTextCheckerClientBase* client)
^~~~~~~~~~~~~~~~~~~~~~~
WebCore::TextCheckerClient
and similarly in WebTextCheckerClient.cpp:
Source/WebKit2/UIProcess/WebTextCheckerClient.cpp:27:
Source/WebKit2/UIProcess/WebTextCheckerClient.h:36:32: error: unknown type name 'WKTextCheckerClientBase'; did you mean 'WebCore::TextCheckerClient'?
template<> struct ClientTraits<WKTextCheckerClientBase> {
^~~~~~~~~~~~~~~~~~~~~~~
WebCore::TextCheckerClient
---
It's defined in Source/WebKit2/UIProcess/API/C/WKTextChecker.h, and that was modified a few weeks ago as part of <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Automatic Text Replacement Testing in WebKit2"
href="show_bug.cgi?id=161919">bug #161919</a>, r206261.
Looking at that commit, it looks VERY wrong. There's a ton of defined(__APPLE__) checks which are clearly incorrect. The changes look related to toolkit, not platform.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>