[Webkit-unassigned] [Bug 158083] LLInt should support other types of prototype GetById caching.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158083

--- Comment #119 from Keith Miller <keith_miller at apple.com> ---
(In reply to comment #118)
> Comment on attachment 291039 [details]
> Patch
> 
> I remember Keith did a patch similar to this in the LLInt for prototype
> values and we didn't see a measurable speedup from it. 
> 
> Should we be doing optimizations like this in the LLInt? Is it worth the
> complexity and maintenance cost?
> 
> What's the best benchmark result we have from this? Do we have any results
> that are not tailored micro benchmarks?

I think I agree with Geoff here. Looking at this patch again, it's difficult to understand exactly what it's doing. If we don't have a measurable speedup from this on a non-microbenchmark, I'm not sure we should take the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161011/55225207/attachment.html>