<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083#c119">Comment # 119</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083">bug 158083</a>
from <span class="vcard"><a class="email" href="mailto:keith_miller@apple.com" title="Keith Miller <keith_miller@apple.com>"> <span class="fn">Keith Miller</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158083#c118">comment #118</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=291039&action=diff" name="attach_291039" title="Patch">attachment 291039</a> <a href="attachment.cgi?id=291039&action=edit" title="Patch">[details]</a></span>
> Patch
>
> I remember Keith did a patch similar to this in the LLInt for prototype
> values and we didn't see a measurable speedup from it.
>
> Should we be doing optimizations like this in the LLInt? Is it worth the
> complexity and maintenance cost?
>
> What's the best benchmark result we have from this? Do we have any results
> that are not tailored micro benchmarks?</span >
I think I agree with Geoff here. Looking at this patch again, it's difficult to understand exactly what it's doing. If we don't have a measurable speedup from this on a non-microbenchmark, I'm not sure we should take the patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>