[Webkit-unassigned] [Bug 163088] Web Inspector: AXI: focused/focusable state should be based on Accessibility Object instead of Element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163088

--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 290941
  --> https://bugs.webkit.org/attachment.cgi?id=290941
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290941&action=review

>>> Source/WebCore/ChangeLog:13
>>> +        LayoutTests/inspector/dom/getAccessibilityPropertiesForNode.html
>> 
>> Maybe the code is exercised by that test, but does that test show the bug? If it did, then there would need to be a test result update in this patch.
> 
> I ran the test with the new code and the result was consistant with the result. Would that suffice?

Darin has a point. If this change is fixing an issue, then there should be a test that shows what changed. The existing test didn't change its results, so whatever this patch is fixing is not included in that test! Ideally you would update the test to cover the case that this patch fixes. That will ensure the issue fixed by this patch doesn't regress in the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161011/f0999a29/attachment-0001.html>