<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: AXI: focused/focusable state should be based on Accessibility Object instead of Element"
href="https://bugs.webkit.org/show_bug.cgi?id=163088#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: AXI: focused/focusable state should be based on Accessibility Object instead of Element"
href="https://bugs.webkit.org/show_bug.cgi?id=163088">bug 163088</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=290941&action=diff" name="attach_290941" title="Patch">attachment 290941</a> <a href="attachment.cgi?id=290941&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=290941&action=review">https://bugs.webkit.org/attachment.cgi?id=290941&action=review</a>
<span class="quote">>>> Source/WebCore/ChangeLog:13
>>> + LayoutTests/inspector/dom/getAccessibilityPropertiesForNode.html
>>
>> Maybe the code is exercised by that test, but does that test show the bug? If it did, then there would need to be a test result update in this patch.
>
> I ran the test with the new code and the result was consistant with the result. Would that suffice?</span >
Darin has a point. If this change is fixing an issue, then there should be a test that shows what changed. The existing test didn't change its results, so whatever this patch is fixing is not included in that test! Ideally you would update the test to cover the case that this patch fixes. That will ensure the issue fixed by this patch doesn't regress in the future.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>