[Webkit-unassigned] [Bug 163125] [GTK] Use libgcrypt instead of GnuTLS for CryptoDigest and SubtleCrypto HMAC implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163125

--- Comment #10 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #8)
> This is actually copied from CryptoAlgorithmHMACGnuTLS.cpp, from Igalia.
> 
> Is the following fine?
> 
> + * Copyright (C) 2014 Igalia S.L.
> + * Copyright (C) 2016 SoftAtHome

Yeah, that's fine.

A lot of files have those bogus notices unfortunately. :( I guess Apple's lawyers would complain if they thought it was a problem, but let's avoid adding it in new places.

> I wondered about this too, but this is also copied from the gnutls flavor.
> The Mac flavor is also ignoring the failure callback.
> 
> I can use failureCallback, not sure about unwanted side-effects.

Hm, if all ports are ignoring the failure callback, that's a little concerning as that indicates the failure cases must never be tested... anyway, that's a preexisting issue; seems safest to ignore it for now.

> It still has a "GCRYPT_FOUND" comment on top, while the file never defines
> it.

Ew, good catch; I didn't notice.

> Another alternative is this one:
> https://quickgit.kde.org/?p=kwallet.
> git&a=blob&h=20053f1a790c99d5d75c495ed7c3255867d4efb7&hb=23344979ed047053256e
> 21638338ef67a1a937ff&f=cmake%2FFindLibGcrypt.cmake

I would use the KDE one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161008/c24f7ff1/attachment.html>