<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use libgcrypt instead of GnuTLS for CryptoDigest and SubtleCrypto HMAC implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=163125#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use libgcrypt instead of GnuTLS for CryptoDigest and SubtleCrypto HMAC implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=163125">bug 163125</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=163125#c8">comment #8</a>)
<span class="quote">> This is actually copied from CryptoAlgorithmHMACGnuTLS.cpp, from Igalia.
>
> Is the following fine?
>
> + * Copyright (C) 2014 Igalia S.L.
> + * Copyright (C) 2016 SoftAtHome</span >
Yeah, that's fine.
A lot of files have those bogus notices unfortunately. :( I guess Apple's lawyers would complain if they thought it was a problem, but let's avoid adding it in new places.
<span class="quote">> I wondered about this too, but this is also copied from the gnutls flavor.
> The Mac flavor is also ignoring the failure callback.
>
> I can use failureCallback, not sure about unwanted side-effects.</span >
Hm, if all ports are ignoring the failure callback, that's a little concerning as that indicates the failure cases must never be tested... anyway, that's a preexisting issue; seems safest to ignore it for now.
<span class="quote">> It still has a "GCRYPT_FOUND" comment on top, while the file never defines
> it.</span >
Ew, good catch; I didn't notice.
<span class="quote">> Another alternative is this one:
> <a href="https://quickgit.kde.org/?p=kwallet">https://quickgit.kde.org/?p=kwallet</a>.
> git&a=blob&h=20053f1a790c99d5d75c495ed7c3255867d4efb7&hb=23344979ed047053256e
> 21638338ef67a1a937ff&f=cmake%2FFindLibGcrypt.cmake</span >
I would use the KDE one.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>