[Webkit-unassigned] [Bug 161450] No reliable way to get a snapshot of WKWebView (macOS)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161450

--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 288770
  --> https://bugs.webkit.org/attachment.cgi?id=288770
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288770&action=review

I know you are in a hurry, but we need to be cautious about creating API that we will have to live with for a long time.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:886
> +    // Software snapshot will not capture elements rendered with hardware acceleration (WebGL, video, etc).

If true, I am not sure it is acceptable to create API that will fail in this manner for so much content?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:895
> +                    auto rawHandler = (void (^)(CGImageRef, NSError *))handler.get();

I believe there is a way to do this without all these typecast casts to the block type, perhaps by using the equivalence of blocks and lambdas.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161007/fe368605/attachment.html>