<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - No reliable way to get a snapshot of WKWebView (macOS)"
href="https://bugs.webkit.org/show_bug.cgi?id=161450#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - No reliable way to get a snapshot of WKWebView (macOS)"
href="https://bugs.webkit.org/show_bug.cgi?id=161450">bug 161450</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=288770&action=diff" name="attach_288770" title="Patch">attachment 288770</a> <a href="attachment.cgi?id=288770&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=288770&action=review">https://bugs.webkit.org/attachment.cgi?id=288770&action=review</a>
I know you are in a hurry, but we need to be cautious about creating API that we will have to live with for a long time.
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:886
> + // Software snapshot will not capture elements rendered with hardware acceleration (WebGL, video, etc).</span >
If true, I am not sure it is acceptable to create API that will fail in this manner for so much content?
<span class="quote">> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:895
> + auto rawHandler = (void (^)(CGImageRef, NSError *))handler.get();</span >
I believe there is a way to do this without all these typecast casts to the block type, perhaps by using the equivalence of blocks and lambdas.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>