[Webkit-unassigned] [Bug 163006] Network Session: PendingDownload is always nullptr in DownloadManager::dataTaskBecameDownloadTask

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=163006

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290813|0                           |1
        is obsolete|                            |
 Attachment #290813|review?                     |
              Flags|                            |
 Attachment #290932|                            |review?
              Flags|                            |

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 290932
  --> https://bugs.webkit.org/attachment.cgi?id=290932&action=review
Different patch

I changed the approach in the end, to make sure the pending download is alive until the didReceiveResponse completion handler is called. That way we can be sure that our NetowkrDataTask always have a valid client at that point, no matter if the download was started by startDownload or convertTasktoDownload. It allows us to report errors while creating the destination before the Download object is created.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161007/1ac3dc10/attachment.html>