<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Session: PendingDownload is always nullptr in DownloadManager::dataTaskBecameDownloadTask"
href="https://bugs.webkit.org/show_bug.cgi?id=163006">bug 163006</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #290813 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #290813 Flags</td>
<td>review?
</td>
<td>
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #290932 Flags</td>
<td>
</td>
<td>review?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Session: PendingDownload is always nullptr in DownloadManager::dataTaskBecameDownloadTask"
href="https://bugs.webkit.org/show_bug.cgi?id=163006#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Network Session: PendingDownload is always nullptr in DownloadManager::dataTaskBecameDownloadTask"
href="https://bugs.webkit.org/show_bug.cgi?id=163006">bug 163006</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=290932&action=diff" name="attach_290932" title="Different patch">attachment 290932</a> <a href="attachment.cgi?id=290932&action=edit" title="Different patch">[details]</a></span>
Different patch
I changed the approach in the end, to make sure the pending download is alive until the didReceiveResponse completion handler is called. That way we can be sure that our NetowkrDataTask always have a valid client at that point, no matter if the download was started by startDownload or convertTasktoDownload. It allows us to report errors while creating the destination before the Download object is created.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>