[Webkit-unassigned] [Bug 162972] [GStreamer][OWR] GL rendering support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162972

--- Comment #5 from Zan Dobersek <zan at falconsigh.net> ---
(In reply to comment #3)
> Comment on attachment 290711 [details]
> [OpenWebRTC][GStreamerGL] Fix video rendering
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=290711&action=review
> 
> >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:361
> >> +    owr_video_renderer_set_request_context_callback(OWR_VIDEO_RENDERER(m_videoRenderer.get()), (OwrVideoRendererRequestContextCallback) MediaPlayerPrivateGStreamerBase::requestGLContext, this, nullptr);
> > 
> > This should use a static_cast<>.
> 
> Doesn't build:
> 
> MediaPlayerPrivateGStreamerOwr.cpp:361:196: error: invalid static_cast from
> type ‘GstContext*(const gchar*, WebCore::MediaPlayerPrivateGStreamerBase*)
> {aka _GstContext*(const char*, WebCore::MediaPlayerPrivateGStreamerBase*)}’
> to type ‘OwrVideoRendererRequestContextCallback {aka _GstContext* (*)(const
> char*, void*)}’
>     
> owr_video_renderer_set_request_context_callback(OWR_VIDEO_RENDERER(m_videoRen
> derer.get()),
> static_cast<OwrVideoRendererRequestContextCallback>(MediaPlayerPrivateGStream
> erBase::requestGLContext), this, nullptr);

:shrugemoji:

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161007/077493b5/attachment-0001.html>