<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GStreamer][OWR] GL rendering support"
href="https://bugs.webkit.org/show_bug.cgi?id=162972#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GStreamer][OWR] GL rendering support"
href="https://bugs.webkit.org/show_bug.cgi?id=162972">bug 162972</a>
from <span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=162972#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=290711&action=diff" name="attach_290711" title="[OpenWebRTC][GStreamerGL] Fix video rendering">attachment 290711</a> <a href="attachment.cgi?id=290711&action=edit" title="[OpenWebRTC][GStreamerGL] Fix video rendering">[details]</a></span>
> [OpenWebRTC][GStreamerGL] Fix video rendering
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=290711&action=review">https://bugs.webkit.org/attachment.cgi?id=290711&action=review</a>
>
> >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:361
> >> + owr_video_renderer_set_request_context_callback(OWR_VIDEO_RENDERER(m_videoRenderer.get()), (OwrVideoRendererRequestContextCallback) MediaPlayerPrivateGStreamerBase::requestGLContext, this, nullptr);
> >
> > This should use a static_cast<>.
>
> Doesn't build:
>
> MediaPlayerPrivateGStreamerOwr.cpp:361:196: error: invalid static_cast from
> type ‘GstContext*(const gchar*, WebCore::MediaPlayerPrivateGStreamerBase*)
> {aka _GstContext*(const char*, WebCore::MediaPlayerPrivateGStreamerBase*)}’
> to type ‘OwrVideoRendererRequestContextCallback {aka _GstContext* (*)(const
> char*, void*)}’
>
> owr_video_renderer_set_request_context_callback(OWR_VIDEO_RENDERER(m_videoRen
> derer.get()),
> static_cast<OwrVideoRendererRequestContextCallback>(MediaPlayerPrivateGStream
> erBase::requestGLContext), this, nullptr);</span >
:shrugemoji:</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>