[Webkit-unassigned] [Bug 162972] [GStreamer][OWR] GL rendering support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162972

Zan Dobersek <zan at falconsigh.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290711|review?                     |review+
              Flags|                            |

--- Comment #2 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 290711
  --> https://bugs.webkit.org/attachment.cgi?id=290711
[OpenWebRTC][GStreamerGL] Fix video rendering

View in context: https://bugs.webkit.org/attachment.cgi?id=290711&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:227
> +    GstContext* context = requestGLContext(contextType, this);

Immediate adopt should be done here.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:361
> +    owr_video_renderer_set_request_context_callback(OWR_VIDEO_RENDERER(m_videoRenderer.get()), (OwrVideoRendererRequestContextCallback) MediaPlayerPrivateGStreamerBase::requestGLContext, this, nullptr);

This should use a static_cast<>.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161006/ef3702a1/attachment-0001.html>