<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer][OWR] GL rendering support"
href="https://bugs.webkit.org/show_bug.cgi?id=162972">bug 162972</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #290711 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer][OWR] GL rendering support"
href="https://bugs.webkit.org/show_bug.cgi?id=162972#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer][OWR] GL rendering support"
href="https://bugs.webkit.org/show_bug.cgi?id=162972">bug 162972</a>
from <span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=290711&action=diff" name="attach_290711" title="[OpenWebRTC][GStreamerGL] Fix video rendering">attachment 290711</a> <a href="attachment.cgi?id=290711&action=edit" title="[OpenWebRTC][GStreamerGL] Fix video rendering">[details]</a></span>
[OpenWebRTC][GStreamerGL] Fix video rendering
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=290711&action=review">https://bugs.webkit.org/attachment.cgi?id=290711&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:227
> + GstContext* context = requestGLContext(contextType, this);</span >
Immediate adopt should be done here.
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:361
> + owr_video_renderer_set_request_context_callback(OWR_VIDEO_RENDERER(m_videoRenderer.get()), (OwrVideoRendererRequestContextCallback) MediaPlayerPrivateGStreamerBase::requestGLContext, this, nullptr);</span >
This should use a static_cast<>.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>