[Webkit-unassigned] [Bug 159398] [test262] Fixing mapped arguments object property test case

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159398

--- Comment #68 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 290429
  --> https://bugs.webkit.org/attachment.cgi?id=290429
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290429&action=review

> Source/JavaScriptCore/runtime/DirectArguments.h:117
> +    void initConfigurableMap(VM&);
> +    void initConfigurableMapIfNecessary(VM&);
> +    void setConfigurable(VM&, unsigned index, bool value);
> +    bool isConfigurable(VM&, unsigned index);

Why not make these functions on GenericArguments since this is defined the same way inside both?

> Source/JavaScriptCore/runtime/DirectArguments.h:157
> +    AuxiliaryBarrier<bool*> m_configurableMap;

Ditto here, why not make this a field inside GenericArguments?

> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:226
> +

please revert.

> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:243
> + ;       if (thisObject->canAccessIndexQuickly(i + offset))

Please revert

> Source/JavaScriptCore/runtime/ScopedArguments.cpp:182
> +    initConfigurableMapIfNecessary(vm);

Is this necessary? Can't you just do
if (!m_configurableMap)
   return true;
?

> Source/JavaScriptCore/runtime/ScopedArguments.h:152
> +    AuxiliaryBarrier<bool*> m_configurableMap;

Please move this field below the m_totalLength field for better alignment. (Or move it to GenericAruments as commented above)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161003/f56b0464/attachment.html>