<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [test262] Fixing mapped arguments object property test case"
href="https://bugs.webkit.org/show_bug.cgi?id=159398#c68">Comment # 68</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [test262] Fixing mapped arguments object property test case"
href="https://bugs.webkit.org/show_bug.cgi?id=159398">bug 159398</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=290429&action=diff" name="attach_290429" title="Patch">attachment 290429</a> <a href="attachment.cgi?id=290429&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=290429&action=review">https://bugs.webkit.org/attachment.cgi?id=290429&action=review</a>
<span class="quote">> Source/JavaScriptCore/runtime/DirectArguments.h:117
> + void initConfigurableMap(VM&);
> + void initConfigurableMapIfNecessary(VM&);
> + void setConfigurable(VM&, unsigned index, bool value);
> + bool isConfigurable(VM&, unsigned index);</span >
Why not make these functions on GenericArguments since this is defined the same way inside both?
<span class="quote">> Source/JavaScriptCore/runtime/DirectArguments.h:157
> + AuxiliaryBarrier<bool*> m_configurableMap;</span >
Ditto here, why not make this a field inside GenericArguments?
<span class="quote">> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:226
> +</span >
please revert.
<span class="quote">> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:243
> + ; if (thisObject->canAccessIndexQuickly(i + offset))</span >
Please revert
<span class="quote">> Source/JavaScriptCore/runtime/ScopedArguments.cpp:182
> + initConfigurableMapIfNecessary(vm);</span >
Is this necessary? Can't you just do
if (!m_configurableMap)
return true;
?
<span class="quote">> Source/JavaScriptCore/runtime/ScopedArguments.h:152
> + AuxiliaryBarrier<bool*> m_configurableMap;</span >
Please move this field below the m_totalLength field for better alignment. (Or move it to GenericAruments as commented above)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>