[Webkit-unassigned] [Bug 165104] Blacklist Netflix for TouchBar support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165104

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #295516|review?                     |review+
              Flags|                            |

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 295516
  --> https://bugs.webkit.org/attachment.cgi?id=295516
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295516&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:7142
> +static bool needsPlaybackControlsManagerQuirk(bool needsQuirks, const URL& url)

I think I would have suggested having this take a Page& argument rather than having the caller dig out the boolean and the URL.

> Source/WebCore/html/HTMLMediaElement.cpp:7148
> +    if (!needsQuirks)
> +        return false;
> +
> +    String host = url.host();
> +    return equalLettersIgnoringASCIICase(host, "www.netflix.com");

I think this would read better without the local variable. Maybe even just a one-liner:

    return needsQuirks && equalLettersIgnoringASCIICase(url.host(), "www.netflix.com");

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161128/1096aace/attachment.html>