<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Blacklist Netflix for TouchBar support"
href="https://bugs.webkit.org/show_bug.cgi?id=165104">bug 165104</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #295516 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Blacklist Netflix for TouchBar support"
href="https://bugs.webkit.org/show_bug.cgi?id=165104#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Blacklist Netflix for TouchBar support"
href="https://bugs.webkit.org/show_bug.cgi?id=165104">bug 165104</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=295516&action=diff" name="attach_295516" title="Patch">attachment 295516</a> <a href="attachment.cgi?id=295516&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=295516&action=review">https://bugs.webkit.org/attachment.cgi?id=295516&action=review</a>
<span class="quote">> Source/WebCore/html/HTMLMediaElement.cpp:7142
> +static bool needsPlaybackControlsManagerQuirk(bool needsQuirks, const URL& url)</span >
I think I would have suggested having this take a Page& argument rather than having the caller dig out the boolean and the URL.
<span class="quote">> Source/WebCore/html/HTMLMediaElement.cpp:7148
> + if (!needsQuirks)
> + return false;
> +
> + String host = url.host();
> + return equalLettersIgnoringASCIICase(host, "www.netflix.com");</span >
I think this would read better without the local variable. Maybe even just a one-liner:
return needsQuirks && equalLettersIgnoringASCIICase(url.host(), "www.netflix.com");</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>